-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add dynamodb restriction #251
base: master
Are you sure you want to change the base?
Conversation
63f99be
to
1db9a1d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 58.52% 50.70% -7.82%
==========================================
Files 13 17 +4
Lines 1408 2191 +783
==========================================
+ Hits 824 1111 +287
- Misses 548 1040 +492
- Partials 36 40 +4 ☔ View full report in Codecov by Sentry. |
121a547
to
aa1b790
Compare
Makefile
Outdated
@@ -38,11 +38,9 @@ endif | |||
all: manager | |||
|
|||
mock: | |||
go install github.com/golang/mock/mockgen@v1.6.0 | |||
go install go.uber.org/mock/mockgen@v0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.5.0 is the latest.
https://github.com/uber-go/mock/releases/tag/v0.5.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated the lib to v0.5.0, and bump go version to 1.22.
aa1b790
to
0d9babe
Compare
…ount Signed-off-by: Yu Jiang <[email protected]>
0d9babe
to
f5114dd
Compare
close #
Could you share the solution in high level?
uber.org/mock
, add mocks to git repoCould you share the test results?