Get version using restAPI #2242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huong Nguyen <[email protected]>
| def get_version_response(): | ||
| """API response for `/api/version`.""" | ||
| installed_version = __version__ | ||
| latest_version = "0.5.0" # how do i check the latest version? |
There was a problem hiding this comment.
from kedro_viz.integrations.pypi import get_latest_version, is_running_outdated_version
There was a problem hiding this comment.
use the same logic as we do in graphql
latest_version = get_latest_version()
is_outdated=is_running_outdated_version(installed_version, latest_version),
added 8 commits
January 17, 2025 16:13
Signed-off-by: Huong Nguyen <[email protected]>
Signed-off-by: Huong Nguyen <[email protected]>
Signed-off-by: Huong Nguyen <[email protected]>
Signed-off-by: Huong Nguyen <[email protected]>
Signed-off-by: Huong Nguyen <[email protected]>
Signed-off-by: Huong Nguyen <[email protected]>
Signed-off-by: Huong Nguyen <[email protected]>
Signed-off-by: Huong Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2221 , in order to remove graphql completely, we need to update the part of get version to restAPI.
I'm currently looking at strange failed test https://github.com/kedro-org/kedro-viz/actions/runs/12827700845/job/35770224311?pr=2242, if you have any idea why this has failed please let me know. Otherwise feel free to review the rest of the PR
QA notes
If you pull the branch and restart the build, everything should work fine. You can also log the
responseincheckKedroVizVersion()written insidewrapper.js. It should log 3 valuesis_outdated, installed, and latestChecklist
RELEASE.mdfile