-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added datadogMetricsService and fix datadogNamespace key in triggerAu… #1469
Conversation
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
Thanks, duplicate of: #1451 |
Hello @zroubalik , but this PR fix the namespace as well. |
@alvarobacelar thanks, haven't notice that. Could you please rebase this PR ? |
…thentication Signed-off-by: Alvaro Bacelar <[email protected]>
…thentication na versao 2.16 Signed-off-by: Alvaro Bacelar <[email protected]>
@zroubalik I've been done. |
Signed-off-by: Alvaro Bacelar <[email protected]>
Hi @zroubalik. is it everything ok with this PR? |
Hello, @JorTurFer. |
@zroubalik what happened with this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @alvarobacelar !
Sorry for the delay, a lot of stuff on my backlog :)
Included
datadogMetricsService
and fixeddatadogNamespace
key in triggerAuthenticatio specs. When I have been Tried this configurations I got errors. After I fix this keys, provide in this PR, works well.Checklist
Fixes #