Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Procedure for Setting Up Autoscaling with KEDA #1446

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shubhusion
Copy link

Description of Changes

Created a procedure for setting up a scaler in KEDA.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Issue Fixed

Fixes kedacore/keda-docs#1368

@shubhusion shubhusion requested a review from a team as a code owner August 5, 2024 16:47
Copy link

github-actions bot commented Aug 5, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit a1fe428
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66bae126fa686b0008d9f57a
😎 Deploy Preview https://deploy-preview-1446--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@shubhusion
Copy link
Author

shubhusion commented Aug 5, 2024

Hi @zroubalik ,@JorTurFer,

Could you please review the finalized PR for #1368? The changes you specified in the previous PR #1415 have been implemented here. However, due to an issue with rebasing, I had to close the earlier PR.

Thank you!

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The only point is that we should include it also as part of v2.16 (if you rebase the branch the folder will be there).

There is another question that comes to my mind, maybe we could transform this into a getting started that we place in the getting started section instead of a versioned documentation. WDYT @tomkerkhove @zroubalik ?
Maybe we can do it in a following PR just refactoring a bit this one (which is nice, tbh)

@shubhusion
Copy link
Author

shubhusion commented Aug 13, 2024

Looks good to me! The only point is that we should include it also as part of v2.16 (if you rebase the branch the folder will be there).

There is another question that comes to my mind, maybe we could transform this into a getting started that we place in the getting started section instead of a versioned documentation. WDYT @tomkerkhove @zroubalik ? Maybe we can do it in a following PR just refactoring a bit this one (which is nice, tbh)

@JorTurFer Included in v2.16 also and file is present in Getting Started Section for v2.15 and v2.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a Procedure for Setting Up a Scaler
2 participants