Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearify confusing example #1403

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlonGluz
Copy link
Contributor

@AlonGluz AlonGluz commented Jun 6, 2024

  • align examples after looking at the code
  • align examples after looking at the code

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@AlonGluz AlonGluz requested a review from a team as a code owner June 6, 2024 08:50
Copy link

github-actions bot commented Jun 6, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 2547b81
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6670249b4556480008413f4c
😎 Deploy Preview https://deploy-preview-1403--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomkerkhove
Copy link
Member

Hey, may I ask why you are changing this? I believe true is the default?

@AlonGluz
Copy link
Contributor Author

AlonGluz commented Jun 9, 2024

@tomkerkhove Simply because it is confusing. The values and the comments don't match the example, Optional. Use to disable HPA ownership validation on this ScaledObject.
Also when looking at the code it skips the validation is the value is false
https://github.com/kedacore/keda/blob/fd4fcc3dcb6eb86e745c310f71c93526ed99ba61/apis/keda/v1alpha1/scaledobject_webhook.go#L224

@AlonGluz
Copy link
Contributor Author

@tomkerkhove WDYT?

@tomkerkhove
Copy link
Member

@tomkerkhove Simply because it is confusing. The values and the comments don't match the example, Optional. Use to disable HPA ownership validation on this ScaledObject. Also when looking at the code it skips the validation is the value is false kedacore/keda@fd4fcc3/apis/keda/v1alpha1/scaledobject_webhook.go#L224

This is the criteria for disabling which is different from the default value though, which is true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants