Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ClusterCloudEventSource #1398

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Introduce ClusterCloudEventSource #1398

merged 2 commits into from
Nov 7, 2024

Conversation

SpiritZhou
Copy link
Contributor

Introduce ClusterCloudEventSource

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes # kedacore/keda#5816

@SpiritZhou SpiritZhou requested a review from a team as a code owner May 28, 2024 03:03
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented May 28, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 77cec35
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/672c6bb2a148cf0008c69404
😎 Deploy Preview https://deploy-preview-1398--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tomkerkhove
tomkerkhove approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

content/docs/2.15/operate/events.md Outdated Show resolved Hide resolved
@SpiritZhou
Update
06eedbe 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou SpiritZhou force-pushed the spiritzhou/clustercloudevent branch from 19d1925 to 06eedbe Compare July 11, 2024 05:08
tomkerkhove
tomkerkhove approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for feature to merge

@JorTurFer JorTurFer merged commit f565629 into kedacore:main Nov 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpiritZhou @tomkerkhove @JorTurFer