Remove cortexOrgID from Prometheus scaler from docs #1324
+0
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: MeenuyD <[email protected]>
MeenuyD
force-pushed
the
remove-cortexOrgID
branch
from
282e1ce
to
0507cf2
Compare
tomkerkhove
requested changes
Feb 28, 2024
| @@ -22,7 +22,6 @@ triggers: | |||
| activationThreshold: '5.5' | |||
| # Optional fields: | |||
| namespace: example-namespace # for namespaced queries, eg. Thanos | |||
| cortexOrgID: my-org # DEPRECATED: This parameter is deprecated as of KEDA v2.10 in favor of customHeaders and will be removed in version 2.12. Use custom headers instead to set X-Scope-OrgID header for Cortex. (see below) | |||
There was a problem hiding this comment.
We should only remove it from the version where it was removed though (2.14)
There was a problem hiding this comment.
Only have to remove it in 2.12?
There was a problem hiding this comment.
no no, this parameter has been in the code until v2.13 (latest released). The version v2.14 will be the first one without it, so there should be the change :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with the deprecation of cortexOrgID in v2.10 and its scheduled removal in v2.12, this commit removes all references to cortexOrgID within the Prometheus scaler documentation.
kedacore/keda#5539 (comment)