Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow linking to FAQ headers #1273

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: Allow linking to FAQ headers #1273

merged 1 commit into from
Dec 11, 2023

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Dec 11, 2023 •
edited
Loading

Allow linking to FAQ headers for easier link sharing which also generates a button to copy the link:
image

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to #1272

@tomkerkhove tomkerkhove requested a review from a team as a code owner December 11, 2023 07:13
@netlify Netlify
Copy link

netlify bot commented Dec 11, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 96c9ca6
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6576b6aabd857a00089f2955
😎 Deploy Preview https://deploy-preview-1273--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@tomkerkhove tomkerkhove mentioned this pull request Dec 11, 2023
Open
1 task
@tomkerkhove tomkerkhove enabled auto-merge (squash) December 11, 2023 07:18
@tomkerkhove tomkerkhove merged commit 995946f into main Dec 11, 2023
9 checks passed
@tomkerkhove tomkerkhove deleted the tomkerkhove-patch-2 branch December 11, 2023 13:32
@zroubalik
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomkerkhove @zroubalik @JorTurFer