feat(openal-info): Add values related to sources inside openal-info.c #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcat
reviewed
Nov 29, 2023
utils/openal-info.c
Outdated
| @@ -148,6 +154,10 @@ static void printALCInfo(ALCdevice *device) | |||
| printf("ALC extensions:"); | |||
| printList(alcGetString(device, ALC_EXTENSIONS), ' '); | |||
| checkALCErrors(device); | |||
| printALCIntegerValue(device, ALC_MONO_SOURCES, "ALC_MONO_SOURCES"); | |||
| checkALCErrors(device); | |||
| printALCIntegerValue(device, ALC_STEREO_SOURCES, "ALC_STEREO_SOURCES"); | |||
There was a problem hiding this comment.
This should be done after the context is created and made current. It would also make sense to put the checkALCErrors call by the alc* calls that could cause an error, and avoid printing the values if there was an error since the variable would be uninitialized in that case.
There was a problem hiding this comment.
Yes, my bad :x, it's fixed
MathiusD
added a commit
to MathiusD/openal-soft
that referenced
this pull request
Nov 29, 2023
CF following comment : kcat#940 (comment)
CF following comment : kcat#940 (comment)
MathiusD
force-pushed
the
feature/openal-info/add_source_info
branch
from
950ad31
to
0f0f7e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to add sources values inside openal-info