Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the official libmysofa repo #1046

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

ThreeDeeJay
Copy link
Contributor

I decided to submit your suggestion to set a higher but safe SOFA limit as a PR in the official libmysofa repo and thankfully it was accepted and merged. So I figured it's time to switch off my temporary fork and use the latest official commit directly.

To verify it, you can try the test with old makemhr which should fail with Invalid error
And updating makemhr.exe to the new one should allow converting it:

Generating "EAC_Default_CustomGrid_-90_90_5_0_360_5_48kHz_UniqueCartesianCoordinates-48000.mhr"
Using 2 threads.
Reading HRTF data from EAC_Default_CustomGrid_-90_90_5_0_360_5_48kHz_UniqueCartesianCoordinates.sofa...
Unexpected delay attribute: _Netcdf4Coordinates = <null>
Unexpected IR attribute: _Netcdf4Coordinates = <null>
Detecting compatible layout...
Using 2394 of 2506 IRs.
Loading HRIRs... 2506 of 2506
Calculating HRIR onsets... 4788 of 4788
Calculating HRIR magnitudes... 4788 of 4788
Calculating diffuse-field average...
Performing diffuse-field equalization...
Synthesizing missing elevations...
Performing minimum phase reconstruction...
100% done (4788 of 4788)
Truncating minimum-phase HRIRs...
Normalizing final HRIRs...
Calculating impulse delays...
Creating MHR data set Output\EAC_Default_CustomGrid_-90_90_5_0_360_5_48kHz_UniqueCartesianCoordinates\EAC_Default_CustomGrid_-90_90_5_0_360_5_48kHz_UniqueCartesianCoordinates-48000.mhr...
Operation completed.

@kcat kcat merged commit 3a8393b into kcat:master Sep 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants