-
-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Booleans handler like pluralization #767
base: v8.x
Are you sure you want to change the base?
Implementation of Booleans handler like pluralization #767
Conversation
Codecov Report
@@ Coverage Diff @@
## v8.x #767 +/- ##
=========================================
+ Coverage 96.26% 96.3% +0.03%
=========================================
Files 10 10
Lines 803 811 +8
=========================================
+ Hits 773 781 +8
Misses 30 30
Continue to review full report at Codecov.
|
@robinsondotnet |
@robinsondotnet would you like me to write the documentation for this so that it can be merged? |
@Soviut Sure. Thanks. |
What is the status on this PR? Is the documentation already written, could I help here? |
@DutchGerman I'm sorry, I don't think I ever received the notification for this back in August. I'll have to refamiliarize myself but I do want this to get merged. |
@robinsondotnet I've been working on the docs but will need to collaborate with you to contribute them to this PR. I've never had to contribute to a 3rd party PR before so I'm not sure if I need to be invited as a contributor to it or something? @kazupon I've got most of the English documentation done, but I'm wondering what I need to do about the zh pages. For example, I've created a new |
@Soviut Thanks! I have invited you as collaborator to |
no eta to know when it will be merged? |
@robinsondotnet I fixed the merge conflict in the tests. This could be merged. |
@kazupon I'm not sure who I should be asking for final review and merge on this, so I'm pinging you. |
The last PR to be merged in this repo was in 2022, so don't expect too much. |
Continued development on |
This PR is related to the following issue: #722