dashboard: Add view for PR runs #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afinn12
force-pushed
the
pr-view
branch
3 times, most recently
from
cdc6a92 to
8405c7e
Compare
a1icja
suggested changes
Nov 6, 2024
afinn12
force-pushed
the
pr-view
branch
2 times, most recently
from
df17116 to
af17d13
Compare
This was referenced Nov 18, 2024
a1icja
reviewed
Nov 19, 2024
pages/index.js
Outdated
Comment on lines
9
to
18
| const [loading, setLoading] = useState(true); | ||
| const [jobs, setJobs] = useState([]); | ||
| const [checks, setChecks] = useState([]); | ||
| const [rowsPR, setRowsPR] = useState([]); | ||
| const [rowsNightly, setRowsNightly] = useState([]); | ||
| const [expandedRows, setExpandedRows] = useState([]); | ||
| const [display, setDisplay] = useState("nightly"); |
There was a problem hiding this comment.
Could we revert the spacing changes here? While it looks nicer, it can be annoying to maintain without requiring a linter.
scripts/fetch-ci-nightly-data.js
Outdated
|
|
||
| // Set token used for making Authorized GitHub API calls. | ||
| // In dev, set by .env file; in prod, set by GitHub Secret. | ||
| require('dotenv').config(); |
There was a problem hiding this comment.
Does this work when ran by GH Actions?
scripts/fetch-ci-nightly-data.js
Outdated
| } | ||
| const json = await response.json(); | ||
| fetch_count++; | ||
| return await json; |
There was a problem hiding this comment.
return await is an anti-pattern. You can use just return.
scripts/fetch-ci-nightly-data.js
Outdated
| @@ -146,78 +122,16 @@ function get_job_data(run) { | |||
| conclusion: null, | |||
| jobs: [], | |||
| }; | |||
| if (run["status"] == "in_progress") { | |||
| if (run["status"] === "in_progress") { | |||
There was a problem hiding this comment.
Is there a reason we're increasing how strict we are? Generally curious.
scripts/fetch-ci-pr-data.js
Outdated
|
|
||
|
|
||
| // Set token used for making Authorized GitHub API calls | ||
| require('dotenv').config(); |
Added a script that fetches PR data and created a separate view on the dashboard. Tweaked dotenv require. Fixes kata-containers#1 Signed-off-by: Anna Finn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed
To Do
Description
Testing
Tested in production with data fetched from:
instead of:
Data must be refetched before pushing (see Needed above)
Nightly View:
PR View
