Bump Go version to 1.22.11 #6066
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @y1hao! It looks like this is your first PR to karmada-io/karmada 🎉 |
karmada-bot
added
the
size/XS
y1hao
commented
Jan 19, 2025
| @@ -37,7 +37,7 @@ KARMADA_METRICS_ADAPTER_LABEL="karmada-metrics-adapter" | |||
|
|
|||
| KARMADA_GO_PACKAGE="github.com/karmada-io/karmada" | |||
|
|
|||
| MIN_Go_VERSION=go1.22.9 | |||
| MIN_Go_VERSION=go1.22.11 | |||
There was a problem hiding this comment.
- The casing is a bit weird - should it be
MIN_GO_VERSION? Maybe I can change it in a separate PR? - Is this version always in sync with the versions in
.go-versionandgo.mod?How about just reading it fromActually, I think this can work:.go-version?MIN_GO_VERSION="go$(go list -m -f {{.GoVersion}})"
|
The 2 failing unit tests in CI in |
Signed-off-by: Yihao Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump Go version to latest 1.22 release.
Which issue(s) this PR fixes:
Fixes #6063
Special notes for your reviewer:
Does this PR introduce a user-facing change?: