Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance ensureWork to continue processing clusters after individual failures #6061

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Jan 17, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

When ensureWork, one cluster fails would prevent other clusters from syncing, this PR aims to enhance ensureWork to continue processing clusters after individual failures.

reproduce method:

  • create any simple deployment and pp
  • add a finalizer to the work in karmada-es-member1 namespace to prevent that work from being deleted
  • delete the deployment (residual work in karmada-es-member1 will remain)
  • recreate deployment, then no work will be created (a more reasonable result is member1's work creation fails, while other clusters succeed)

just like:

kubectl create deploy nginx --image=nginx
kubectl get deploy nginx -o yaml | karmadactl apply --all-clusters=true -f -

kubectl patch work nginx-687f7fb96f --type='json' -p '[{"op": "add", "path": "/metadata/finalizers/1", "value": "test"}]' -n karmada-es-member1

kubectl delete deploy nginx
kubectl create deploy nginx --image=nginx

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 17, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 48.36%. Comparing base (ce41488) to head (42d1f47).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controllers/binding/common.go 50.00% 12 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6061      +/-   ##
==========================================
- Coverage   48.36%   48.36%   -0.01%     
==========================================
  Files         666      666              
  Lines       54842    54847       +5     
==========================================
- Hits        26527    26526       -1     
- Misses      26595    26599       +4     
- Partials     1720     1722       +2     
Flag Coverage Δ
unittests 48.36% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2025
@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2025
@chaosi-zju
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants