-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance ensureWork to continue processing clusters after individual failures #6061
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6061 +/- ##
==========================================
- Coverage 48.36% 48.36% -0.01%
==========================================
Files 666 666
Lines 54842 54847 +5
==========================================
- Hits 26527 26526 -1
- Misses 26595 26599 +4
- Partials 1720 1722 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
90823d3
to
b403bed
Compare
…ailures Signed-off-by: chaosi-zju <[email protected]>
b403bed
to
42d1f47
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
When
ensureWork
, one cluster fails would prevent other clusters from syncing, this PR aims to enhanceensureWork
to continue processing clusters after individual failures.reproduce method:
finalizer
to thework
inkarmada-es-member1
namespace to prevent thatwork
from being deletedwork
inkarmada-es-member1
will remain)work
will be created (a more reasonable result is member1's work creation fails, while other clusters succeed)just like:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: