Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add automatic memory limit handling #6059

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dongjiang1989
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Enable automatic detection of memory limits and configure GOMEMLIMIT to match.Also includes a flag to allow controlling the reserved ratio.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add automatic memory limit handling

Signed-off-by: dongjiang <[email protected]>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign garrybest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 16, 2025
Signed-off-by: dongjiang <[email protected]>
Signed-off-by: dongjiang <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 38 lines in your changes missing coverage. Please review.

Project coverage is 48.35%. Comparing base (ce41488) to head (70a075a).

Files with missing lines Patch % Lines
cmd/aggregated-apiserver/app/options/options.go 0.00% 5 Missing ⚠️
cmd/metrics-adapter/app/options/options.go 0.00% 3 Missing ⚠️
operator/cmd/operator/app/options/options.go 0.00% 3 Missing ⚠️
pkg/goruntime/memory.go 85.71% 2 Missing and 1 partial ⚠️
cmd/agent/app/agent.go 0.00% 2 Missing ⚠️
cmd/controller-manager/app/controllermanager.go 0.00% 2 Missing ⚠️
cmd/descheduler/app/descheduler.go 0.00% 2 Missing ⚠️
cmd/karmada-search/app/karmada-search.go 0.00% 2 Missing ⚠️
cmd/scheduler-estimator/app/options/options.go 0.00% 2 Missing ⚠️
cmd/scheduler-estimator/app/scheduler-estimator.go 0.00% 2 Missing ⚠️
... and 8 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6059      +/-   ##
==========================================
- Coverage   48.36%   48.35%   -0.02%     
==========================================
  Files         666      667       +1     
  Lines       54842    54898      +56     
==========================================
+ Hits        26527    26546      +19     
- Misses      26595    26631      +36     
- Partials     1720     1721       +1     
Flag Coverage Δ
unittests 48.35% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants