Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto go maxprocs #6047

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dongjiang1989
Copy link
Contributor

@dongjiang1989 dongjiang1989 commented Jan 14, 2025

What type of PR is this?

/kind feature
What this PR does / why we need it:
auto setting gomaxprocs

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

In Kubernetes env, the containers spec as follows:

  containers:
  - args:
    image: docker.io/karmada/karmada-scheduler:v1.12.2
    imagePullPolicy: IfNotPresent
    resources:
      limits:
        cpu: "4" 
        memory: 8Gi
      requests:
        cpu: "4"
        memory: 8Gi

In Runtime Information of Prometheus:

GOMAXPROCS:  96   // The host CPUs number, I'd like to see the values of `containers.requests` 4

In this case, the Go program scheduling or GC pause may cost too long.

The library automaxprocs has solved the problem that Go programs cannot set GOMAXPROCS correctly in the case of Containers.

Does this PR introduce a user-facing change?:

auto setting gomaxprocs

Signed-off-by: dongjiang <[email protected]>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 14, 2025
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 10.81081% with 33 lines in your changes missing coverage. Please review.

Project coverage is 48.34%. Comparing base (446dbe9) to head (1e086f7).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
cmd/agent/app/agent.go 0.00% 3 Missing ⚠️
cmd/aggregated-apiserver/app/options/options.go 0.00% 3 Missing ⚠️
cmd/controller-manager/app/controllermanager.go 0.00% 3 Missing ⚠️
cmd/descheduler/app/descheduler.go 0.00% 3 Missing ⚠️
cmd/karmada-search/app/karmada-search.go 0.00% 3 Missing ⚠️
cmd/metrics-adapter/app/options/options.go 0.00% 3 Missing ⚠️
cmd/scheduler-estimator/app/scheduler-estimator.go 0.00% 3 Missing ⚠️
cmd/scheduler/app/scheduler.go 0.00% 3 Missing ⚠️
cmd/webhook/app/webhook.go 0.00% 3 Missing ⚠️
operator/cmd/operator/app/operator.go 0.00% 3 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6047      +/-   ##
==========================================
- Coverage   48.35%   48.34%   -0.01%     
==========================================
  Files         666      667       +1     
  Lines       54831    54879      +48     
==========================================
+ Hits        26513    26531      +18     
- Misses      26599    26627      +28     
- Partials     1719     1721       +2     
Flag Coverage Δ
unittests 48.34% <10.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: dongjiang <[email protected]>
Signed-off-by: dongjiang <[email protected]>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

I will take a look, probably by this week.

also, appreciated if you can give us some background of this, especially why do you think it's necessary.

@dongjiang1989
Copy link
Contributor Author

/assign

I will take a look, probably by this week.

also, appreciated if you can give us some background of this, especially why do you think it's necessary.

Thanks. Got it.
Add notes done.

Signed-off-by: dongjiang <[email protected]>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rainbowmango. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants