-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add auto go maxprocs #6047
base: master
Are you sure you want to change the base?
feat: add auto go maxprocs #6047
Conversation
Signed-off-by: dongjiang <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6047 +/- ##
==========================================
- Coverage 48.35% 48.34% -0.01%
==========================================
Files 666 667 +1
Lines 54831 54879 +48
==========================================
+ Hits 26513 26531 +18
- Misses 26599 26627 +28
- Partials 1719 1721 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: dongjiang <[email protected]>
Signed-off-by: dongjiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
I will take a look, probably by this week.
also, appreciated if you can give us some background of this, especially why do you think it's necessary.
Thanks. Got it. |
Signed-off-by: dongjiang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
auto setting gomaxprocs
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
In Kubernetes env, the containers spec as follows:
In Runtime Information of Prometheus:
In this case, the Go program scheduling or GC pause may cost too long.
The library automaxprocs has solved the problem that Go programs cannot set
GOMAXPROCS
correctly in the case of Containers.Does this PR introduce a user-facing change?: