Update .pre-commit-config.yaml #286
Conversation
|
Hi, looks like the lint tasks are still failing |
| - --verbose | ||
| - --ignore=tests/conftest.py | ||
|
|
||
| - repo: https://github.com/adrienverge/yamllint |
There was a problem hiding this comment.
Keep in mind we already have this hook: https://github.com/jumanjihouse/pre-commit-hook-yamlfmt
could it cause a problem? I mean, will the 2 diffferent yaml linters/formatters interfere with each other? If both are actually needed, then could it be done in such a way that the second one will only care about the line length (by ignoring all other rules/formatting?)
There was a problem hiding this comment.
yes u r right, I have configured one of the linter to ignore line length, by making yamlfmt to only check line length
|
Per docs in yamlfmt:
So yamllint won't affect the behavior. Then to run yamlfmt to only check line-width is with |
@stroncod ,thanks i have set the width. please check. |
|
let me see |
There was a problem hiding this comment.
Now it's giving these errors
usage: yamlfmt [-h] [-m MAPPING] [-s SEQUENCE] [-o OFFSET] [-c] [-w WIDTH]
[-p] [--implicit_start | --explicit_start]
[--implicit_end | --explicit_end] [-n]
[FILE_NAME ...]
yamlfmt: error: unrecognized arguments: --line-length=80
usage: yamlfmt [-h] [-m MAPPING] [-s SEQUENCE] [-o OFFSET] [-c] [-w WIDTH]
[-p] [--implicit_start | --explicit_start]
[--implicit_end | --explicit_end] [-n]
[FILE_NAME ...]
yamlfmt: error: unrecognized arguments: --line-length=80
remove print statements..................................................Passed
yamllint.................................................................Failed
- hook id: yamllint
- exit code: 2
usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA]
[-f {parsable,standard,colored,github,auto}] [-s]
[--no-warnings] [-v]
[FILE_OR_DIR ...]
yamllint: error: unrecognized arguments: --width=[80](https://github.com/kantord/SeaGOAT/actions/runs/6388169149/job/17344055464?pr=286#step:6:81)
usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA]
[-f {parsable,standard,colored,github,auto}] [-s]
[--no-warnings] [-v]
[FILE_OR_DIR ...]
yamllint: error: unrecognized arguments: --width=80
btw you can run it locally using pre-commit run --all-files that should also make sure that it passes on the CI
it used --width 80 format, in both yamlint and yamlfmt, |
it used --width format , but still it giving linting error in yamlint |
|
That's because yamlint does not have the
Try using the flag on yamlfmt and not on yamlint. |
ohk i have done it, please check |
hi, it's still failing from what I can see |
Hello, Yes it's still failing. Any suggestions? |
It fails because yamlfmt does not modify the files, only notifies you. You can run a script to solve that after yamlfmt tells you which files you need |
|
Also now the branch needs to be rebased it seems |
Solving issue #275
Please check @kantord , i have used yamllint
i have done it under hacktoberfest2023