Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 8 TFM #1349

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Add .NET 8 TFM #1349

merged 3 commits into from
Feb 19, 2024

Conversation

hwoodiwiss
Copy link
Member

@hwoodiwiss hwoodiwiss commented Feb 17, 2024

Adds .NET 8 as a supported TFM.
Makes some changes based on API's that have become deprecated with .NET 8.

@hwoodiwiss hwoodiwiss added WIP .NET Pull requests that update .net code enhancement labels Feb 17, 2024
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cbbd0d) 78.96% compared to head (04ac779) 79.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
+ Coverage   78.96%   79.19%   +0.23%     
==========================================
  Files         138      138              
  Lines        3232     3230       -2     
  Branches      450      450              
==========================================
+ Hits         2552     2558       +6     
+ Misses        449      441       -8     
  Partials      231      231              
Flag Coverage Δ
linux 79.19% <100.00%> (+0.23%) ⬆️
macos 47.77% <100.00%> (-0.01%) ⬇️
windows 47.86% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hwoodiwiss hwoodiwiss removed the WIP label Feb 17, 2024
@hwoodiwiss hwoodiwiss marked this pull request as ready for review February 17, 2024 23:13
@hwoodiwiss hwoodiwiss requested a review from a team as a code owner February 17, 2024 23:13
@martincostello martincostello added this to the v7.2.0 milestone Feb 18, 2024
@slang25 slang25 merged commit e8aa7e3 into main Feb 19, 2024
14 checks passed
@slang25 slang25 deleted the hwoodiwiss-net-8-tfm branch February 19, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants