Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Native AOT #1348
base: main
Are you sure you want to change the base?
Support Native AOT #1348
Changes from 13 commits
84f51ac
0a7db70
74ed1f0
68d150e
067b3a9
0f4cb43
61aa172
f05572c
773f7fc
4334fe7
ffa2d31
470e3fe
0cf53a3
bb28ec4
b5e6c64
5ae305a
aadf5dc
9744507
b74891d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 72 in src/JustSaying.Extensions.DependencyInjection.Microsoft/IServiceCollectionExtensions.cs
Codecov / codecov/patch
src/JustSaying.Extensions.DependencyInjection.Microsoft/IServiceCollectionExtensions.cs#L72
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
might be problematic for AoT in case it's a derived type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's a good point, I think it'll end up serializing the base fields, but none added by the derived type.
At the moment,
RedrivePolicy
is only used internally, and I can't see a way that an API user could derive it and pass it through to any internal usage, but I could be missing it.If that is the case, I don't think it would be a bad idea to
internal sealed
it.Check warning on line 14 in src/JustSaying/Extensions/JsonElementExtensions.cs
Codecov / codecov/patch
src/JustSaying/Extensions/JsonElementExtensions.cs#L14
Check warning on line 17 in src/JustSaying/Extensions/JsonElementExtensions.cs
Codecov / codecov/patch
src/JustSaying/Extensions/JsonElementExtensions.cs#L16-L17
Check warning on line 20 in src/JustSaying/Extensions/JsonElementExtensions.cs
Codecov / codecov/patch
src/JustSaying/Extensions/JsonElementExtensions.cs#L19-L20
Check warning on line 23 in src/JustSaying/Extensions/JsonElementExtensions.cs
Codecov / codecov/patch
src/JustSaying/Extensions/JsonElementExtensions.cs#L23
Check warning on line 14 in src/JustSaying/Extensions/JsonSerializerOptionsExtensions.cs
Codecov / codecov/patch
src/JustSaying/Extensions/JsonSerializerOptionsExtensions.cs#L13-L14