-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAI provider #19
Conversation
Just pushed to resolve the |
dee9fb2
to
ee784b0
Compare
Seems to be working fine locally for both the chat and completer: jupyterlite-ai-openai.mp4For the inline completer, there seems to be some issues similar to the other providers. Maybe there is something to be done to improve the quality of the suggestions in general, by checking the response against the input used when the completer was triggered. |
} | ||
return 'Unknown provider'; | ||
} | ||
|
||
/* | ||
* Get an LLM completer from the name. | ||
*/ | ||
export function getSettings(name: string): JSONObject | null { | ||
export function getSettings(name: string): any { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this any
is fine for now, but we should maybe check if we can put JSONObject | null
back as the return type.
Marking as ready for now since it seems to be functional. |
I'm not clear about the usage of the |
LGTM, I can't approve it |
No description provided.