Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make taggers manifest functions #2252

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

Free functions work as good as Class.staticmethod, but are much shorter.

@mathbunnyru
Copy link
Member Author

mathbunnyru commented Mar 12, 2025

I checked locally and created files stayed the same (except built time).
There was only a slight change in the command output (due to changes from CamelCase to snake_case), which is completely fine.

@mathbunnyru mathbunnyru merged commit 2c1df40 into jupyter:main Mar 12, 2025
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant