Provide mechanism for managing resources across engines and executions #4281

YongGoose · 2025-01-27T11:42:17Z

Resolves #2816

Overview

Designing a class to manage context at the platform level
Adding a session-level store to LauncherSession
Adding a request-level store to Launcher
Exposing the request-level store in ~~EngineDiscoveryRequest and TestPlan~~ ExecutionRequest
Utilizing the request-level store in ExtensionContext
Tests for Jupiter, Suite engine, EngineTestKit etc.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

There are no TODOs left in the code
Method preconditions are checked and documented in the method's Javadoc
Coding conventions (e.g. for logging) have been followed
Change is covered by automated tests including corner cases, errors, and exception handling
Public API has Javadoc and @API annotations
Change is documented in the User Guide and Release Notes

YongGoose · 2025-01-27T12:00:54Z

What's the use case for this method? Test engines don't have access to the Launcher so we'll need to pass this store as part of LauncherDiscoveryRequest and ExecutionRequest, don't we?

I’ve drafted an initial version 02ef45b , but I think there’s still a lot of room for improvement.
If you could point out any mistakes I’ve made, I’ll make sure to fix them right away.

Even though I’ve been studying, I find it quite challenging.

PS. While resolving a git conflict, I accidentally included the commit history from the main branch, So i create a new PR 😁

YongGoose · 2025-01-27T12:12:29Z

@marcphilipp

I think you must be very busy with the release of version 5.12 M1.
Please feel free to leave your comments whenever it’s convenient for you.

YongGoose · 2025-02-06T10:53:01Z

@marcphilipp

~~This PR is something I’ve personally been eager to work on for a long time.~~
~~However, I still don’t have a clear sense of how to proceed with it.~~

~~If this feature gets added to JUnit 5, it would be a huge learning opportunity for me and a great addition to my skill set.~~
~~That said, I don’t want to cause any fatigue for the JUnit team—especially you, Marc.~~

~~So if you feel that I’m not quite ready to take on this PR yet, please let me know, and I’ll close it.~~
~~Either way, I’ll keep looking for other issues and do my best to contribute! 🙂~~

I think I sounded a bit too weak.
After completing the other PR, I will make sure to implement this perfectly, no matter what.

~~But if you’re willing to let me see it through, I’ll do my best as always.~~
~~I’ll likely need more guidance than usual compared to other tasks.~~

marcphilipp · 2025-02-09T10:08:27Z

junit-jupiter-api/src/main/java/org/junit/jupiter/api/extension/ExtensionContext.java

+	 * @return the store for session-level data
+	 * @since 5.13
+	 */
+	Store getSessionLevelStore();


These also need an @API annotation:

@API(status = EXPERIMENTAL, since = "5.13")

Done in 33f5fb8

...ngine/src/main/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStore.java

junit-platform-engine/src/main/java/org/junit/platform/engine/Namespace.java

junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncher.java

...platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncherSession.java

...piter-engine/src/main/java/org/junit/jupiter/engine/descriptor/AbstractExtensionContext.java

junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/LauncherFactory.java

...orm-launcher/src/main/java/org/junit/platform/launcher/core/EngineExecutionOrchestrator.java

platform-tests/src/test/java/org/junit/platform/launcher/core/DefaultLauncherTests.java

YongGoose

Removing the store from the discovery process sounds like a good idea.
As the next step, I will proceed with the following task.

Tests for Jupiter, Suite engine, EngineTestKit etc.

Thank you, Marc!

junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncher.java

...platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncherSession.java

junit-platform-launcher/src/main/java/org/junit/platform/launcher/LauncherSession.java

YongGoose · 2025-03-03T05:48:32Z

@marcphilipp

While working on the tests, I have a question.

As per your guidance, I am adding tests for JupiterEngine, SuiteEngine, and EngineKit. However, I am wondering if SuiteEngine requires furthermore testing.

Since the main focus of this PR is adding request-level and session-level stores, I am designing the tests around that.

The execute method in SuiteEngine utilizes the requestLevelStore from ExecutionRequest to run multiple tests. In my view, the core role of execute is to execute multiple tests, and this functionality is already being validated by existing tests.

Do you think any additional tests are needed for SuiteEngine?

PS. I truly appreciate how you not only explain things but also implement the code to make communication more efficient—it’s been incredibly helpful. 👍🏻
However, this time, I’d like to try implementing it on my own! 🙂

...testFixtures/java/org/junit/platform/launcher/core/NamespacedHierarchicalStoreProviders.java

marcphilipp · 2025-03-05T08:29:19Z

The execute method in SuiteEngine utilizes the requestLevelStore from ExecutionRequest to run multiple tests. In my view, the core role of execute is to execute multiple tests, and this functionality is already being validated by existing tests.

Do you think any additional tests are needed for SuiteEngine?

I was thinking about a very basic tests that verifies that SuiteEngine passes along the requestLevelStore to test engines. It's probably sufficient to mock SuiteLauncher and check that a non-null store is passed to it.

Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>

Issue: junit-team#2816

Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>

Issue: junit-team#2816

YongGoose · 2025-03-13T10:05:44Z

@marcphilipp

I have a seminar presentation tomorrow, so it will be difficult for me to work on this.
Apologies for the delay.

I will complete the work by next week or this weekend and request a review then.

marcphilipp · 2025-03-13T16:03:29Z

No worries! Good luck for your presentation!

Issue: junit-team#2816

YongGoose · 2025-03-17T12:00:16Z

@marcphilipp

Currently, the dummyTest in JupiterTest is failing. This happens because JupiterTest runs in isolation, attempting to retrieve a value from session-level-store without first inserting it, resulting in a NullPointerException.

One possible solution is to modify JupiterExtensionExample to allow null values to pass, but I don’t think this is the best approach.

WDYT?

marcphilipp · 2025-03-18T15:49:17Z

The convention we have adopted after LauncherFactoryTests was initially written is to name test classes that should not be run directly (for example, because they're used by a test via EngineTestKit or directly via the Launcher) with a TestCase suffix. This avoids them being picked up due to this config:

junit5/gradle/plugins/common/src/main/kotlin/junitbuild.testing-conventions.gradle.kts

Line 67 in 0f585b2

include("**/*Test.class", "**/*Tests.class")

So I'd suggest renaming JupiterTest to JupiterTestCase accordingly. This also applies to the JUnit4Example and JUnit5Example classes.

platform-tests/src/test/java/org/junit/platform/launcher/core/LauncherFactoryTests.java

…LauncherFactoryTests.java Co-authored-by: Marc Philipp <[email protected]>

YongGoose · 2025-03-18T21:36:44Z

The convention we have adopted after LauncherFactoryTests was initially written is to name test classes that should not be run directly (for example, because they're used by a test via EngineTestKit or directly via the Launcher) with a TestCase suffix. This avoids them being picked up due to this config:

junit5/gradle/plugins/common/src/main/kotlin/junitbuild.testing-conventions.gradle.kts

Line 67 in 0f585b2

include("**/*Test.class", "**/*Tests.class")

So I'd suggest renaming JupiterTest to JupiterTestCase accordingly. This also applies to the JUnit4Example and JUnit5Example classes.

Done in e56946f !

YongGoose · 2025-03-18T21:41:27Z

@marcphilipp

I'm planning to move on to the documentation work. 🚀
Would it be possible to check if there's anything else that should be added to the tests?

Also, if you could recommend which part of file should be updated or where a new document should be added, that would be really helpful.

Writing documentation is always a challenge! 😅

Issue: junit-team#2816

marcphilipp

Would it be possible to check if there's anything else that should be added to the tests?

The main thing I'm missing is integration tests that verifies AutoCloseable objects put into the request-level store get closed after execution and those put into the session-level store get closed when the LauncherSession is closed.

Also, if you could recommend which part of file should be updated or where a new document should be added, that would be really helpful.

We should update the usage example to store HttpServer (or a wrapper, if necessary) in the session-level store, retrieve it from a new ParameterResolver extension and inject it into the test rather than using system properties.

Moreover, we should add a new "Managing State Across Test Engines" subsection to JUnit Platform Launcher API where we provide an example of two test engines lazily creating and sharing a resource (maybe the same HttpServer or a wrapper thereof as in the other example?) regardless of which is executed first.

marcphilipp · 2025-03-19T08:50:58Z

...-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/ClassExtensionContext.java

+	 *
+	 * @see #ClassExtensionContext(ExtensionContext, EngineExecutionListener, ClassBasedTestDescriptor, Lifecycle, JupiterConfiguration, ExtensionRegistry, LauncherStoreFacade, ThrowableCollector)
+	 */
+	ClassExtensionContext(ExtensionContext parent, EngineExecutionListener engineExecutionListener,


This is unused, isn't it?

It seems to be unused.
I'll remove it!

marcphilipp · 2025-03-19T08:52:33Z

junit-platform-engine/src/main/java/org/junit/platform/engine/support/store/Namespace.java

+import org.apiguardian.api.API;
+import org.junit.platform.commons.util.Preconditions;
+
+@API(status = EXPERIMENTAL, since = "5.13")


This should be 1.13 since it's in a Platform module.

marcphilipp · 2025-03-19T08:54:01Z

junit-platform-engine/src/main/java/org/junit/platform/engine/support/store/Namespace.java

+import org.junit.platform.commons.util.Preconditions;
+
+@API(status = EXPERIMENTAL, since = "5.13")
+public class Namespace {


Please add class-level Javadoc here.

marcphilipp · 2025-03-19T08:55:03Z

junit-platform-engine/src/main/java/org/junit/platform/engine/support/store/Namespace.java

+	 * existing sequence of parts in this namespace.
+	 *
+	 * @return new namespace; never {@code null}
+	 * @since 5.13


There's no need to repeat this for a method if it's identical to the class' @since tag. Please remove it.

marcphilipp · 2025-03-19T08:55:23Z

junit-platform-engine/src/main/java/org/junit/platform/engine/support/store/Namespace.java

+	 * @return new namespace; never {@code null}
+	 * @since 5.13
+	 */
+	@API(status = STABLE, since = "5.13")


This should also be removed to "inherit" it from the class.

marcphilipp · 2025-03-19T09:26:23Z

platform-tests/src/test/java/org/junit/platform/launcher/core/LauncherFactoryTests.java

+	static class JupiterExtensionExample implements BeforeAllCallback {
+		@Override
+		public void beforeAll(ExtensionContext context) {
+			var value = context.getRoot().getStore(ExtensionContext.Namespace.GLOBAL).get("testKey");


There should be no need to call getRoot() here. Please also check that we can get the value from context.getSessionLevelStore(ExtensionContext.Namespace.GLOBAL) as well.

marcphilipp · 2025-03-19T09:28:13Z

...platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncherSession.java

@@ -73,11 +83,17 @@ LauncherSessionListener getListener() {
 	public void close() {
 		if (launcher.delegate != ClosedLauncher.INSTANCE) {
 			launcher.delegate = ClosedLauncher.INSTANCE;
+			store.close();
 			listener.launcherSessionClosed(this);


To allow the listener to read things from the store, we should first call the listener and then close the store.

marcphilipp · 2025-03-19T09:28:36Z

platform-tests/src/test/java/org/junit/platform/launcher/core/LauncherFactoryTests.java

@@ -333,6 +338,29 @@ public void executionFinished(TestIdentifier testIdentifier, TestExecutionResult
 		}));
 	}

+	@Test
+	void extensionCanReadValueFromSessionStore() {


I think we should also test that an extension can store a value in the session-level store that can be read by a LauncherSessionListener in launcherSessionClosed().

marcphilipp · 2025-03-19T09:30:59Z

platform-tests/src/test/java/org/junit/platform/launcher/core/StoreSharingTests.java

+			NamespacedHierarchicalStoreProviders.dummyNamespacedHierarchicalStore());
+
+		engineWriter.execute(request);
+		engineReader.execute(request);


I think we should go through Launcher.execute here rather than calling TestEngine.execute directly. That way, we would also test the Launcher's handling of the store meets our expectations.

marcphilipp · 2025-03-19T09:32:51Z

platform-tests/src/test/java/org/junit/platform/suite/engine/SuiteEngineTests.java

+
+		new SuiteTestEngine().execute(request);
+
+		verify(mockDescriptor).execute(listener, requestLevelStore);


I think we should make the assertion a bit stronger to avoid accidentally depending on any equals() implementation.

Suggested change

verify(mockDescriptor).execute(listener, requestLevelStore);

verify(mockDescriptor).execute(same(listener), same(requestLevelStore));

YongGoose · 2025-03-19T10:51:23Z

The main thing I'm missing is integration tests that verifies AutoCloseable objects put into the request-level store get closed after execution and those put into the session-level store get closed when the LauncherSession is closed.

Thank you so much for your detailed feedback on my work! 🙇🏻‍♂️🙇🏻‍♂️
Since you've reviewed it thoroughly, I'll make sure to refine my work carefully before requesting a review.

YongGoose force-pushed the feature/2816 branch from f6fe9f1 to 02ef45b Compare January 27, 2025 11:52

YongGoose mentioned this pull request Feb 1, 2025

Implement Parallel Method Execution in JUnit-Vintage engine #4242

Merged

6 tasks

marcphilipp self-requested a review February 1, 2025 10:38

marcphilipp reviewed Feb 9, 2025

View reviewed changes

YongGoose commented Feb 12, 2025

View reviewed changes

...piter-engine/src/main/java/org/junit/jupiter/engine/descriptor/AbstractExtensionContext.java Outdated Show resolved Hide resolved

YongGoose force-pushed the feature/2816 branch 3 times, most recently from c9d5ac0 to 7d98e9a Compare February 13, 2025 10:48

YongGoose commented Feb 13, 2025

View reviewed changes

junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/LauncherFactory.java Outdated Show resolved Hide resolved

YongGoose requested a review from marcphilipp February 13, 2025 12:06

YongGoose commented Feb 18, 2025

View reviewed changes

...orm-launcher/src/main/java/org/junit/platform/launcher/core/EngineExecutionOrchestrator.java Outdated Show resolved Hide resolved

YongGoose force-pushed the feature/2816 branch from 7b47567 to d72090c Compare February 21, 2025 10:43

marcphilipp reviewed Feb 24, 2025

View reviewed changes

platform-tests/src/test/java/org/junit/platform/launcher/core/DefaultLauncherTests.java Outdated Show resolved Hide resolved

YongGoose commented Feb 25, 2025

View reviewed changes

marcphilipp reviewed Mar 5, 2025

View reviewed changes

...testFixtures/java/org/junit/platform/launcher/core/NamespacedHierarchicalStoreProviders.java Outdated Show resolved Hide resolved

YongGoose and others added 10 commits March 8, 2025 15:37

Generate ResourceContext for store resources

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

66891a5

Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>

Add getStore method in LauncherSession

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

7b8182c

Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>

Add Namespace by reusing Jupiter's Namespace class

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

d475bcf

Issue: junit-team#2816

Apply comment

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

f25bec2

Issue: junit-team#2816

Adding a request-level store to Launcher

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

7068fff

Issue: junit-team#2816

Apply comment

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

dea6ecc

Issue: junit-team#2816

Generate ResourceContext for store resources

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

d940bd4

Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>

Add Namespace by reusing Jupiter's Namespace class

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

faebb0c

Issue: junit-team#2816

Apply comment

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

365228d

Issue: junit-team#2816

Adding a request-level store to Launcher

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

6018ff2

Issue: junit-team#2816

YongGoose added 2 commits March 11, 2025 15:48

Merge branch 'main' into feature/2816

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

13c03de

Merge branch 'main' into feature/2816

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

579c492

YongGoose added 5 commits March 16, 2025 22:45

polishing

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

Loading
Loading status checks…

3aae750

Issue: junit-team#2816

update tests

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

Loading
Loading status checks…

59d7d0c

Issue: junit-team#2816

Merge branch 'main' into feature/2816

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

64186b9

Merge branch 'main' into feature/2816

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

82a4e97

polishing

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

Loading
Loading status checks…

b76ee64

Issue: junit-team#2816

YongGoose force-pushed the feature/2816 branch from dac543f to aa97f63 Compare March 17, 2025 10:40

Add Jupiter extension test

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

Loading
Loading status checks…

6f4fc2b

Issue: junit-team#2816

YongGoose force-pushed the feature/2816 branch from aa97f63 to 6f4fc2b Compare March 17, 2025 10:51

Add dummy test engines tests

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

Loading
Loading status checks…

1683573

Issue: junit-team#2816

YongGoose force-pushed the feature/2816 branch from 6be4d88 to 1683573 Compare March 17, 2025 10:58

YongGoose requested a review from marcphilipp March 17, 2025 11:02

YongGoose added 2 commits March 18, 2025 09:22

Merge branch 'main' into feature/2816

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

478ef7d

Merge branch 'main' into feature/2816

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

0ee7f84

marcphilipp reviewed Mar 18, 2025

View reviewed changes

platform-tests/src/test/java/org/junit/platform/launcher/core/LauncherFactoryTests.java Outdated Show resolved Hide resolved

YongGoose and others added 2 commits March 19, 2025 06:33

Merge branch 'main' into feature/2816

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

7e65f7f

Apply comment

Verified

This commit was signed with the committer’s verified signature.

YongGoose Yongjun Hong

GPG key ID: 2CB7F4B427C9E5B8

Verified
Learn about vigilant mode

Loading
Loading status checks…

5e98c47

Issue: junit-team#2816

YongGoose force-pushed the feature/2816 branch from e56946f to 5e98c47 Compare March 18, 2025 21:44

marcphilipp self-requested a review March 19, 2025 08:45

Merge branch 'main' into feature/2816

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

bb2f9ed

marcphilipp requested changes Mar 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide mechanism for managing resources across engines and executions #4281

Provide mechanism for managing resources across engines and executions #4281

YongGoose commented Jan 27, 2025 •

edited by marcphilipp

Loading

YongGoose commented Jan 27, 2025 •

edited

Loading

YongGoose commented Jan 27, 2025

YongGoose commented Feb 6, 2025 •

edited

Loading

marcphilipp Feb 9, 2025

YongGoose Feb 12, 2025

YongGoose left a comment •

edited

Loading

YongGoose commented Mar 3, 2025

marcphilipp commented Mar 5, 2025

YongGoose commented Mar 13, 2025

marcphilipp commented Mar 13, 2025

YongGoose commented Mar 17, 2025 •

edited

Loading

marcphilipp commented Mar 18, 2025 •

edited

Loading

YongGoose commented Mar 18, 2025

YongGoose commented Mar 18, 2025

marcphilipp left a comment

marcphilipp Mar 19, 2025

YongGoose Mar 19, 2025

marcphilipp Mar 19, 2025

marcphilipp Mar 19, 2025

marcphilipp Mar 19, 2025

marcphilipp Mar 19, 2025

marcphilipp Mar 19, 2025

marcphilipp Mar 19, 2025

marcphilipp Mar 19, 2025

marcphilipp Mar 19, 2025

marcphilipp Mar 19, 2025

YongGoose commented Mar 19, 2025


		new SuiteTestEngine().execute(request);

		verify(mockDescriptor).execute(listener, requestLevelStore);

	verify(mockDescriptor).execute(listener, requestLevelStore);
	verify(mockDescriptor).execute(same(listener), same(requestLevelStore));

Provide mechanism for managing resources across engines and executions #4281

Are you sure you want to change the base?

Provide mechanism for managing resources across engines and executions #4281

Conversation

YongGoose commented Jan 27, 2025 • edited by marcphilipp Loading

Overview

Definition of Done

YongGoose commented Jan 27, 2025 • edited Loading

YongGoose commented Jan 27, 2025

YongGoose commented Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YongGoose left a comment • edited Loading

Choose a reason for hiding this comment

YongGoose commented Mar 3, 2025

marcphilipp commented Mar 5, 2025

YongGoose commented Mar 13, 2025

marcphilipp commented Mar 13, 2025

YongGoose commented Mar 17, 2025 • edited Loading

marcphilipp commented Mar 18, 2025 • edited Loading

YongGoose commented Mar 18, 2025

YongGoose commented Mar 18, 2025

marcphilipp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YongGoose commented Mar 19, 2025

YongGoose commented Jan 27, 2025 •

edited by marcphilipp

Loading

YongGoose commented Jan 27, 2025 •

edited

Loading

YongGoose commented Feb 6, 2025 •

edited

Loading

YongGoose left a comment •

edited

Loading

YongGoose commented Mar 17, 2025 •

edited

Loading

marcphilipp commented Mar 18, 2025 •

edited

Loading