dev/fix-translate #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative translation moves the image "up" and "left", decreasing the height and width. Vice versa for positive translation.
Not sure of the performance hits here. Also seems as though output_width and char_width are not strictly necessary anymore since we calculate them as we go along. Also changed is that when a wide character gets split by a translate or a region cutoff, the extra space is replaced with '…'. This is necessary at least on the left to avoid jumps when the character appears when scrolling. Not sure if this behavior is also wanted on the right. Is there a "partial character" codepoint for when there isn't enough space to display a full character?
We need to keep track of the number of rows that a call skipped so that in any future calls we can count that many lines as skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes translate behavior when drawing. It mangles the core routine a bit and removes an optimization when
output_width <= remaining_columns, but we need to countskip_col. Maybe it could do the skipping then determine what is left and do the old optimization?The commit messages have more information as well.