[Fix] no-unknown-property support new precedence prop
#3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Sep 23, 2024
|
@ljharb is there a way to accommodate that in the plugin, or does that just mean not adding it until there is a version of the plugin released only for react v19+? |
|
@acusti there is! see the |
acusti
force-pushed
the
no-unknown-property-precedence
branch
from
f57bd9f
to
500112b
Compare
ljharb
reviewed
Oct 22, 2024
| @@ -89,6 +89,7 @@ ruleTester.run('no-unknown-property', rule, { | |||
| { code: '<div onPointerDown={this.onDown} onPointerUp={this.onUp} />' }, | |||
| { code: '<input type="checkbox" defaultChecked={this.state.checkbox} />' }, | |||
| { code: '<div onTouchStart={this.startAnimation} onTouchEnd={this.stopAnimation} onTouchCancel={this.cancel} onTouchMove={this.move} onMouseMoveCapture={this.capture} onTouchCancelCapture={this.log} />' }, | |||
| { code: '<link precedence="medium" href="https://foo.bar" rel="canonical" />' }, | |||
There was a problem hiding this comment.
shouldn't this test case only pass when the react version is set to 19+?
There was a problem hiding this comment.
definitely. i used react: { version: '19.0.0-rc.0' }, but if it makes more sense to do 19.0.0 even though that doesn’t match any released versions, happy to do that.
ljharb
reviewed
Oct 22, 2024
acusti
force-pushed
the
no-unknown-property-precedence
branch
2 times, most recently
from
c249d03
to
df4f665
Compare
acusti
force-pushed
the
no-unknown-property-precedence
branch
from
df4f665
to
ac007b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3827