Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Update Python jsonschema version support #242

Merged
merged 1 commit into from
Nov 4, 2018

Conversation

bquinn
Copy link
Contributor

@bquinn bquinn commented Nov 2, 2018

The linked repo says "Full support for Draft 7, Draft 6, Draft 4 and Draft 3"

The linked repo says "Full support for Draft 7, Draft 6, Draft 4 and Draft 3"
@handrews
Copy link
Contributor

handrews commented Nov 3, 2018

I'll leave this up to @Julian, as he may be waiting for 3.0.0 to get out of alpha status before changing this (FWIW, I'm in favor of advertising the support now particularly as no other Python validators are even close AFAIK)

@Julian
Copy link
Member

Julian commented Nov 4, 2018

That was the rationale yeah (waiting until a stable release).

But if you're both for it I don't feel strongly one way or the other, happy to merge.

@Julian Julian merged commit 8c9356f into json-schema-org:master Nov 4, 2018
@bquinn
Copy link
Contributor Author

bquinn commented Nov 5, 2018

Thanks! I had some colleagues looking at the list and thinking that we shouldn't do our work in Python as the jsonschema implementation was out of date. So I wanted to correct their thinking :-)

@bquinn bquinn deleted the patch-1 branch November 5, 2018 11:14
@mesknock
Copy link

mesknock commented Jan 3, 2019

I think this should be reverted. As of now if you pull down the latest stable build of jsonschema you get 2.6.0 which only supports up to draft-04.

Furthermore, comments on this issue seem to indicate that support for draft-07 is only partially implemented: python-jsonschema/jsonschema#400

If nothing else I believe the notes field should be updated to indicate that this functionality is not currently in the stable release.

@Julian
Copy link
Member

Julian commented Jan 17, 2019

As I mentioned I don't personally really have an opinion one way or the other here :), I would have loved for it to not have mattered and a release to have already gone out but... some day :(

If there's any consensus I am happy to do whatever, but FWIW I'm going to close that issue since essentially everything Draft 7 is in and has been for awhile so that should be fine, I just didn't remember there was a comment about it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants