Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for alpha (0.1.0) release #5

Merged
merged 19 commits into from
Jul 8, 2021
Merged

Prepare for alpha (0.1.0) release #5

merged 19 commits into from
Jul 8, 2021

Conversation

justingrant
Copy link
Contributor

@justingrant justingrant commented Jul 8, 2021 •
edited
Loading

  • update version to 0.1.0
  • copy recent code & test changes from original repo
  • switch CI tests to run Node 14 and 16 (remove 15)
  • run prettier --fix
  • update dependencies
  • update .gitignore

ptomato
ptomato requested changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something I need to check out re. a bug fix in the getNextTransition/getPreviousTransition code, and I'd recommend not removing the big blocks of PlainDate/PlainTime tests, but otherwise this looks good.

test/intl.mjs Show resolved Hide resolved
test/plaintime.mjs Outdated Show resolved Hide resolved
lib/ecmascript.mjs Outdated Show resolved Hide resolved
justingrant and others added 19 commits July 8, 2021 14:31
@justingrant @ptomato
Prefer singular unit names in TS types
52c7530 
Fixes #1487. Also fixes bug in units for PlainTime's until/since.
@justingrant @ptomato
Switch tests from Node 15 to Node 16
c4d10b4
@justingrant @ptomato
Remove workarounds for V8 bugs now fixed in Node14
10c0b11
@ptomato
Consolidate NumberIsInteger and ES.IsInteger in polyfill
b21ab31 
We use the operation from es-abstract in some places, and a snapshot of
Number.isInteger in others. Use IsInteger in order to correspond more with
the spec text.
@Ms2ger @ptomato
Editorial: Clarify Infinity handling in PlainYearMonth constructor.
d904b4b
@Ms2ger @ptomato
Editorial: Clarify Infinity handling in PlainMonthDay constructor.
3e6cd50
@Ms2ger @ptomato
Editorial: Clarify Infinity handling in PlainDate constructor.
1c694dd
@Ms2ger @ptomato
Editorial: Clarify Infinity handling in PlainDateTime constructor.
494f9ce
@Ms2ger @ptomato
Editorial: Clarify Infinity handling in PlainTime constructor.
398a95c
@Ms2ger @ptomato
Editorial: Reverse loop in DifferenceISODate for clarity.
be88a9e
@Ms2ger @ptomato
Editorial: Avoid dividing by zero in ZonedDateTime#round.
36082aa 
Ref. #1502.
@Ms2ger @ptomato
[polyfill] Handle missing argument to withCalendar methods.
bf7a738
@Ms2ger @ptomato
Editorial: Clarify AddZonedDateTime with missing options.
8ed6a69
@Ms2ger @ptomato
Editorial: Return absolute value of dayLengthNs from NanosecondsToDays.
32152be
@Ms2ger @ptomato
[polyfill] Fix Temporal.now methods not to be constructors.
b4165d7
@katemihalikova @ptomato
Add dateStyle/timeStyle to Intl helpers
134987f 
Fixes #1590
@katemihalikova @ptomato
Add dayPeriod to Intl amend helpers
bd35175
@justingrant @ptomato
Fix typo in error message
6486fe7
@justingrant @ptomato
Prepare for alpha (0.1.0) release
55183c8 
* update version to 0.1.0
* copy recent code & test changes from original repo
* switch CI tests to run Node 14 and 16 (remove 15)
* run prettier --fix
* update dependencies
* update .gitignore
@ptomato ptomato merged commit 5a55047 into js-temporal:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

@Ms2ger Ms2ger Awaiting requested review from Ms2ger

@ryzokuken ryzokuken Awaiting requested review from ryzokuken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justingrant @ptomato @Ms2ger @katemihalikova