Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi-Architecture (ARM64) Support for Docker Image #3699

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

LuBashQ
Copy link
Contributor

@LuBashQ LuBashQ commented Nov 19, 2024

Description

Add support for multi-arch Docker images. Built and supported images are:

  • linux/amd64
  • linux/arm64
  • linux/arm/v7

Issues Resolved

Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

The tests have been performed using act to push the created images on my DockerHub repository, available here to try and pull.

Checking the full uname of the containers yields:

  • ARMv7
❯ docker pull --platform linux/arm/v7 cristianlupascu/super-productivity:multiarch-docker-build
❯ docker run -d --rm --platform linux/arm/v7 -p 80:80 cristianlupascu/super-productivity:multiarch-docker-build  
59965a0ee14ace8205018a96deec0c12f01cd14fe5b410c39ba632bbad850b27
❯ docker exec -it 59965a0ee14ace8205018a96deec0c12f01cd14fe5b410c39ba632bbad850b27 /bin/ash
/ # uname -a
Linux 59965a0ee14a 6.10.4-linuxkit #1 SMP Wed Oct  2 16:38:00 UTC 2024 armv7l Linux
  • ARM64
❯ docker pull --platform linux/arm64 cristianlupascu/super-productivity:multiarch-docker-build
❯ docker run -d --rm --platform linux/arm64 -p 80:80 cristianlupascu/super-productivity:multiarch-docker-build  
6e5e7a1bc090ff1f3c0f751ec95210e83638dfd867cfda2e72b2a786aeb78dbd
❯ docker exec -it 6e5e7a1bc090ff1f3c0f751ec95210e83638dfd867cfda2e72b2a786aeb78dbd /bin/ash
/ # uname -a
Linux 6e5e7a1bc090 6.10.4-linuxkit #1 SMP Wed Oct  2 16:38:00 UTC 2024 aarch64 Linux
  • AMD64
❯ docker pull --platform linux/amd64 cristianlupascu/super-productivity:multiarch-docker-build
❯ docker run -d --rm --platform linux/amd64 -p 80:80 cristianlupascu/super-productivity:multiarch-docker-build  
3b17bc2a76114df9bf84e636add603460d3b3cf44efaed724a891c3b8dd65579
❯ docker exec -it 3b17bc2a76114df9bf84e636add603460d3b3cf44efaed724a891c3b8dd65579 /bin/ash
/ # uname -a
Linux 3b17bc2a7611 6.10.4-linuxkit #1 SMP Wed Oct  2 16:38:00 UTC 2024 x86_64 Linux

Create multi-arch Docker images. Currently built platforms are:

* linux/amd64
* linux/arm64
* linux/arm/v7

Signed-off-by: LuBashQ <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there LuBashQ! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@dennysubke
Copy link

Tested it on my Raspberry Pi, and it works flawlessly! 🎉 Excellent work! Everything runs smoothly. The PR looks great as well. 😊

@johannesjo
Copy link
Owner

Thank you very much @LuBashQ !!!

@johannesjo johannesjo merged commit 56497db into johannesjo:master Nov 24, 2024
5 checks passed
@dennysubke
Copy link

dennysubke commented Nov 24, 2024

Thank you so much! Great work! 👍 Now all that’s left is to publish it to Docker Hub. @johannesjo @LuBashQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Add Multi-Architecture (ARM64) Support for Docker Image
3 participants