-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Arch Linux PKGBUILD_template for new artifacts changes #3662
Conversation
@johannesjo Would love if you could give this a quick check, since no matter if I fix manually the AUR package, until this is merged everytime a new version is released, the Arch package breaks |
@johannesjo / @alosarjos - Is this file used by any other builds/distros than Arch Linux? If not, I don't see the point in maintaining it in your repo. If it is used by other distros, I'd prefer if the checksums were actually validated every time instead of skipped. It's a bad security practice to skip them. It adds a little overhead for the AUR maintainer to download the binary releases and do a This is why I'd suggested the patch here. |
@siliconmeadow I'm guessing you are the same user also commenting on the AUR Repo. In order to have software updates delivered fast and easy to AUR @johannesjo and I worked back on the day on automatizing the process through Github actions. @johannesjo kindly accepted adding this automation to the AUR to avoid needing a maintainer to manually update packages and make things easier. It's clear that there are things that can be improved (Like the checksum validation) but we did the best we could back in the day and has worked good enough for almost 4 years. 4 years getting this updated without needing any manual intervention. I personally think that great. I will check if I can automate generating the checksum for the files (I'm more familiar with Gitlab CICD than Github actions), but I think that can go on another merge request. For now this one at least should keep things working as it has until now. |
Thank you very much @alosarjos !!!
How should I check it? Would it be enough to just see if it works for the next release? Or is there a better way? @siliconmeadow |
@alosarjos - thanks for explaining that, it never occurred to me that's what you'd done. Cool cool deal. I'll have a think about how GH actions might be able to produce the checksum somehow. Or does the AUR have full access to Arch's gitlab instance and therefore something can be done via @johannesjo - I might be speaking out of turn, but I think that's probably the only thing you can do is to merge this PR and we see what happens at next release. @alosarjos would need to confirm, of course. |
@johannesjo Lets merge for now, and lets see how next release goes. Things are broken without this PR, things can't go worse :P |
New packaging seems to change a couple of things: 1. Package version is no longer included on the filename of the release artifact 2. Looks like the directory inside the package new includes spaces on the target install dir
Oh. Forgot to hit the merge button :D |
New packaging seems to change a couple of things:
Closes #3656