Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync show gitlab issue detail #2115 #3247

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

hosseinkhaledi
Copy link
Contributor

Description

Use gitlab issue id instead of iid

Issues Resolved

#2115

Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there hosseinkhaledi! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@johannesjo
Copy link
Owner

Thanks you very much for providing this PR! There is a merge conflict. Can you maybe take a look at it?

@johannesjo johannesjo merged commit 2019031 into johannesjo:master Jul 17, 2024
4 of 5 checks passed
@lazybobcat
Copy link

lazybobcat commented Oct 17, 2024

@hosseinkhaledi May I ask why this change, especially in the case of getting the issue details?

The GitLab API URL without the iid (GET /issues/:id) is reserved for administrator. The other API URL (GET /projects/:id/issues/:issue_iid) requires the iid. (documentation)

We maybe could also use issue._links.self that contains the URL (it's used in _getIssueComments$)?

I can implement a fix, but since I'm not familiar with this project nor Gitlab API, I don't wanna break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants