Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was gona try to convert this to ESM but all the
exports[xxxx]encode.bytes = x
made it a bit weird.So i just converted most of the code to use const and let, some default arguments here and there and some arrow fn and also reduced the number of exports by doing something like:
The conversion was mostly done with lebab. Didn't want to do too many changes - afraid to do any breaking stuff when there are no tests...
but the conversion to export an object instead makes it easier to iterate over to try and modernize it a bit furtherer
(have also updated all the dependencies)