Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new xsc git info struct #311

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

orz25
Copy link
Contributor

@orz25 orz25 commented Feb 24, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Use new XscGitInfoContext struct to align the following changes:

@orz25 orz25 added the ignore for release Automatically generated release notes label Feb 24, 2025
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Feb 24, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 24, 2025
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Feb 24, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 24, 2025
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Feb 24, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 24, 2025
@orz25 orz25 requested a review from attiasas February 24, 2025 13:50
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/audit 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/git/audit 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/scm 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/validations 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/xsc 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/git/audit/gitaudit.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/scm/gitmanager.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/validations/test_mocks.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/xsc/analyticsmetrics.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/commands/audit/audit_test.go
  • github.com/jfrog/jfrog-cli-security/git_test.go
  • github.com/jfrog/jfrog-cli-security/utils/scm/gitmanager_test.go
  • github.com/jfrog/jfrog-cli-security/utils/xsc/analyticsmetrics_test.go

Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants