Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dotnet curation tests after Artifactory CLI migration #309

Merged
merged 7 commits into from
Feb 23, 2025

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Feb 19, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

After migrating to jfrog-cli-artifactory the following PR:

Has fix some issues with nuget/dotnet config file for V3, it broke the tests suite for curation since there was a mock server that expects different API URL (added /index.json for the path)

@attiasas attiasas added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Feb 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 19, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 20, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 20, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 20, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 20, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 20, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 20, 2025
@attiasas attiasas changed the title Update deps Fix dotnet curation tests after Artifactory CLI migration Feb 21, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 21, 2025
@attiasas attiasas marked this pull request as ready for review February 21, 2025 07:53
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 21, 2025
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/commands/curation 0.00% (ø)

Coverage by file

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/commands/curation/curationaudit_test.go

@attiasas attiasas requested a review from orto17 February 23, 2025 07:48
@attiasas attiasas merged commit 6e1bf93 into jfrog:dev Feb 23, 2025
59 checks passed
@attiasas attiasas deleted the fix_dotnet branch February 23, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants