Fix Conan timestamp mismatch #529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobiNino
added
safe to test
RobiNino
added
safe to test
RobiNino
force-pushed
the
conan-timestamp
branch
from
f720a55 to
b69a845
Compare
RobiNino
added
safe to test
RobiNino
force-pushed
the
conan-timestamp
branch
from
d7a62ba to
24af32e
Compare
RobiNino
added
safe to test
RobiNino
force-pushed
the
conan-timestamp
branch
from
5a12d53 to
77264c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.Following #528
This PR introduces changes that will improve consistency of the build timestamp for Conan build and their artifacts.
So far a timestamp was generated for every new Conan task, and again when setting the artifact build timestamp property.
The mismatch in timestamp between a build and its artifacts was causing issue when trying to delete the artifacts by their build.
From now on, the timestamp will only be generated once per build.
Tests will pass after merging #530