Make HttpOutput.println() simpler and faster
#12530
Open
+171
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorban
commented
Nov 13, 2024
| } | ||
| finally | ||
| { | ||
| out.release(); |
There was a problem hiding this comment.
If the above write() call is async, out.release() may be called before the write is done.
sbordet
requested changes
Nov 13, 2024
jetty-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/HttpOutput.java
Outdated
Show resolved
Hide resolved
gregw
requested changes
Nov 13, 2024
jetty-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/HttpOutput.java
Outdated
Show resolved
Hide resolved
jetty-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/HttpOutput.java
Outdated
Show resolved
Hide resolved
jetty-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/HttpOutput.java
Outdated
Show resolved
Hide resolved
jetty-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/HttpOutput.java
Outdated
Show resolved
Hide resolved
|
@lorban might want to merge from base |
|
@lorban status report? |
|
@gregw this can now be resumed, so I'm going to refresh my mind then finalize it. |
lorban
force-pushed
the
experiment/jetty-12.1.x/faster-HttpOutput-print
branch
from
77cd88b to
7ab7eb9
Compare
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
lorban
force-pushed
the
experiment/jetty-12.1.x/faster-HttpOutput-print
branch
from
7ab7eb9 to
5f943dc
Compare
lorban
changed the title
HttpOutput.print() HttpOutput.println() simpler and faster
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
HttpOutput.println()by simplifying it, making it faster in most cases and fixes a too early buffer release.