Issue #11092 - Allow MetaInfConfiguration parsing of java.class.path to support globs
#12287
Conversation
…to support globs
| @Test | ||
| public void testSplitOnPathSeparatorWithGlob() throws IOException | ||
| { | ||
| try (ResourceFactory.Closeable resourceFactory = ResourceFactory.closeable()) |
There was a problem hiding this comment.
Could you add another term to the glob string that is just a single jar file, to mimic a classpath that has both glob and individual jar files on it.
There was a problem hiding this comment.
This test kind has that already, 2 non globs, and 1 glob.
Also the existing test testSplitOnPipeWithGlob() has the same.
Do you want the non-glob to be specifically a jar?
There was a problem hiding this comment.
Followup, do you want the extra non-globs to be before or after the glob?
There was a problem hiding this comment.
I don't really mind the position of the jar, just so long as the test is a combination of dirs, a dir with glob and at least one explicit jar.
| Stream.of(classPath.split(File.pathSeparator)) | ||
| .map(resourceFactory::newResource) | ||
| .filter(r -> uriPatternPredicate.test(r.getURI())) | ||
| resourceFactory.split(classPath, File.pathSeparator) |
There was a problem hiding this comment.
Heh, technically we shouldn't fix ee8 and ee9 because they should be bug-for-bug compatible with jetty 10/11. But ok.
There was a problem hiding this comment.
In Jetty 10/11 we ignore globs here.
The raw string is created a File and then if it doesn't exist, it's ignored.
The thing is, a File with a * glob always produces a File instance that doesn't exist (or can be opened).
But a Path cannot even be created with a * glob, it throws an Exception.
|
@joakime some test failures to address here as well. |
|
@joakime is this one ready for re-review? |
Yes. Review away. |
|
@janbartel bump |
Use ResourceFactory.split(String) to properly parse the
java.class.pathso that globs can be supported in MetaInfConfiguration as well.Fixes #11092
Fixes #12283