Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flatten plugin #706

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Commits on Mar 9, 2023

  1. Adds test case for jenkinsci#705

    dependencyManagement can be used to manage the transitive dependency
    versions not only direct ones, and this impacts what can end up in the
    resulting hpi file.
    
    By not including the depMgmt section then any downtream consumer will
    see the un managed versions of the dependencies which will differ from
    what they should see
    jtnord committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    2644ab7 View commit details
    Browse the repository at this point in the history
  2. do not flatten with OSS mode

    the OSS mode despite saying it keeps everything "repositories and
    pluginRepositories" does not and it throws away the dependencyManagement
    
    this creates our own descriptor that dies the same as the oss mode
    currently but additionally keeps the dependencyManagement section
    
    Whilst we could have used resolveCiFriendliesOnly which is probably a
    better solution so that the poms behave better regardless of if they are
    deployed from CI or local snapshots this keeps the changes to published
    poms minimal
    jtnord committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    30885c8 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. switch to expand and adapt test case accordingly

    as discussed with @jglick as the intention of the flatten plugin here is to have
    a self contained pom - this will switch to expand which will also have the benefit
    of picking up any <dependencyManagement> configured in the parent(s).
    jtnord committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d8e7f3a View commit details
    Browse the repository at this point in the history