declare used transitive deps whose version we manage #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to jenkinsci/plugin-pom#705 and https://issues.apache.org/jira/browse/MNG-7003 using dependencyManagement to manage the transitive dependencies is not a good idea if you are going to be consumed by something else. this keeps the dependencyManagement so we can manage the verions as one, but where we use a transitive dependency that has had its version managed we inline it into the dependencies
basil
reviewed
Mar 10, 2023
There was a problem hiding this comment.
https://github.com/jenkinsci/bom/blob/01f2b04ced89b4743411c9fdfe74c9814e37d40b/sample-plugin/pom.xml#L29-L36 can be made less ugly after this PR. The only remaining require upper bound dependencies error after this PR is for org.jetbrains:annotations between okhttp-api and io.jenkins.configuration-as-code:test-harness.
jglick
approved these changes
Mar 10, 2023
|
(suggest labeling as |
raul-arabaolaza
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to jenkinsci/plugin-pom#705 and https://issues.apache.org/jira/browse/MNG-7003 using dependencyManagement to manage the transitive dependencies is not a good idea if you are going to be consumed by something else.
this keeps the dependencyManagement so we can manage the verions as one, but where we use a transitive dependency that has had its version managed we inline it into the dependencies