[JENKINS-72979] Remove trailing space from Windows agent secret file instructions

[debayangg]

See JENKINS-72979.

Testing done

Confirmed with interactive testing that when the space precedes the ">" character on Windows 11 cmd.exe, the output file includes a trailing space. Confirmed with interactive testing that when space that precedes the ">" character is removed, the output file does not include a trailing space.

No automated test because the text is an example command.

Proposed changelog entries

• Remove trailing space from Windows agent secret file instructions.

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@NotMyFault

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[KalleOlaviNiemitalo]

I worried that, if ${it.jnlpMac} ends with a digit, then cmd.exe might treat that as part of a file descriptor redirection operator, like 2> to redirect standard error. But apparently cmd.exe doesn't do that if there are other printable characters adjacent to the last digit. And ${it.jnlpMac} is a hexadecimal number that doesn't contain spaces, so it's OK.

[debayangg]

Can this PR be merged under hacktoberfest?

[MarkEWaite]

Can this PR be merged under hacktoberfest?

As far as I know, Hacktoberfest does not recognize merged pull requests that were submitted before 1 Oct 2024.

[debayangg]

Okay then ig I will try and find some hacktoberfest issues

[NotMyFault]

/label ready-for-merge

---

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!