Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tasklist with checklist in PR template #10301

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Feb 19, 2025

Replace tasklist with checklist in PR template

GitHub announced that they are retiring task lists as of 30 Apr 2025.

They recommend a transition to sub-issues. We don't use GitHub issues for the Jenkins core repository, so let's switch from tasklist to a simple checklist like we use for the Jenkins LTS release checklist.

Testing done

Confirmed that simple checklists are still supported by GitHub and work well.

No automated testing required because this is changing a GitHub pull request template.

Proposed changelog entries

N/A

Proposed changelog category

/label skip-changelog

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

GitHub announced 18 Feb 2025 that they are retiring task lists.
https://github.blog/changelog/2025-02-18-github-issues-projects-february-18th-update/#tasklist-blocks-will-be-retired-and-replaced-with-sub-issues

We don't use GitHub issues for the Jenkins core repository, so let's
switch from tasklist to a simple checklist like we use for the Jenkins
LTS release checklist.
@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label Feb 19, 2025
@MarkEWaite MarkEWaite mentioned this pull request Feb 19, 2025
14 tasks
@MarkEWaite
Copy link
Contributor Author

Closing in favor of

@MarkEWaite MarkEWaite closed this Feb 19, 2025
@MarkEWaite MarkEWaite deleted the switch-from-tasklist-to-checklist branch February 19, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants