Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert oklch usage in core #10282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Feb 16, 2025

#10078 introduces oklch usage in Jenkins core. This PR caused a major regression, see JENKINS-75242 that affects all plugins that use trend charts that are based on the echarts plugin. Some examples are the popular junit, warnings, and coverage plugins.

Since nobody corresponded on the JENKINS-75242 yet, it makes sense to revert the original change until a solution has been found in core or the affected plugins.

Testing done

Manual testing of the charts in my instance. Now all colors are working again when hovering over the chart.

Proposed changelog entries

N/A

Proposed changelog category

/label skip-changelog

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@timja @janfaracik

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@timja timja requested a review from janfaracik February 16, 2025 21:18
@timja
Copy link
Member

timja commented Feb 16, 2025

Looks solvable in echarts-api: apache/echarts#20757

If someone has time to give it a go, otherwise we can revert till sorted.

@janfaracik
Copy link
Contributor

Hey, apologies for not getting back.

I'll take a look and try to fix it in the plugin.

Thanks

@janfaracik
Copy link
Contributor

https://github.com/jenkinsci/echarts-api-plugin/pull/380/files

Opened in draft, needs some more testing

@krisstern krisstern added the skip-changelog Should not be shown in the changelog label Feb 17, 2025
@timja timja added the on-hold This pull request depends on another event/release, and it cannot be merged right now label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold This pull request depends on another event/release, and it cannot be merged right now skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants