Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to notify culprits by looking them up in the Hipchat user API #19

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

bartvangeneugden
Copy link

No description provided.

@aldaris
Copy link

aldaris commented Oct 31, 2014

Thanks for the pull request. I will certainly have a look, but it may take a while to get it merged. At the moment I'm in the process of refactoring some bits around ActiveNotifier and the way it interacts with MessageBuilder, which is very likely to be breaking this pull request unfortunately.

@bartvangeneugden
Copy link
Author

@aldaris Thanks for coming back. Hoping to get this merged at some point so will keep an eye on this Repository!

fixing bug with implementation of BuildStep#perform (see
jenkinsci#20)
@emoshaya
Copy link

This PR would be fantastic! hope it gets merged soon...

@aldaris aldaris self-assigned this Oct 18, 2015
@eheydrick
Copy link

+1

@aldaris
Copy link

aldaris commented Nov 20, 2015

Had a look at this change, but couldn't really find a feasible way to integrate it. The problems:

  • the proposed change uses the deprecated v1 API to figure out the usernames
  • the v2 API doesn't really provide a neat way to obtain the user name (with limited set of OAuth2 scopes).

Whilst it is possible to retrieve all members of a given room (using view_room scope), there is no way to actually perform a search, and to properly deal with get_all_members output, pagination would need to be implemented as well. I assume it would be most preferred if the solution would actually have good performance and wouldn't potentially hit rate limits, but frankly I don't quite see an easy way to accomplish that.

@jhoblitt
Copy link
Member

jhoblitt commented Mar 4, 2016

@bartvangeneugden I think that best approach for jenkins -> HC user mapping is to have an explicit source of truth.

@aviv-ebates
Copy link

aviv-ebates commented Apr 11, 2018

does https://www.hipchat.com/docs/apiv2/method/view_user answers the API issue? /v2/user/{id_or_email}. Scopes: view_group.

@erikpaulmiller
Copy link

What is the status of this? This should definitely be an option in this plugin as the v2 api supports it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants