-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option to notify culprits by looking them up in the Hipchat user API #19
base: master
Are you sure you want to change the base?
Conversation
… them to the message
a users mention name from their email address
StandardHipChatService#getMentionNameFromEmail
Thanks for the pull request. I will certainly have a look, but it may take a while to get it merged. At the moment I'm in the process of refactoring some bits around ActiveNotifier and the way it interacts with MessageBuilder, which is very likely to be breaking this pull request unfortunately. |
@aldaris Thanks for coming back. Hoping to get this merged at some point so will keep an eye on this Repository! |
fixing bug with implementation of BuildStep#perform (see jenkinsci#20)
This PR would be fantastic! hope it gets merged soon... |
+1 |
Had a look at this change, but couldn't really find a feasible way to integrate it. The problems:
Whilst it is possible to retrieve all members of a given room (using view_room scope), there is no way to actually perform a search, and to properly deal with get_all_members output, pagination would need to be implemented as well. I assume it would be most preferred if the solution would actually have good performance and wouldn't potentially hit rate limits, but frankly I don't quite see an easy way to accomplish that. |
@bartvangeneugden I think that best approach for jenkins -> HC user mapping is to have an explicit source of truth. |
does https://www.hipchat.com/docs/apiv2/method/view_user answers the API issue? |
What is the status of this? This should definitely be an option in this plugin as the v2 api supports it. |
No description provided.