-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sarif report: allow file paths in file URI scheme #1102
Conversation
Does this work with % encoding in file: URLs? |
If an exception occurs it falls back to the old value |
I meant, if the SARIF file has "file:///dir/%E2%82%AC", then does this translate it to "/dir/%E2%82%AC" or to "/dir/€"? |
- adapt code accordingly
I added test data to the testcase to clarify this -> its getting translated |
current solution seems to work under windows only... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
============================================
+ Coverage 90.58% 90.59% +0.01%
- Complexity 2323 2328 +5
============================================
Files 357 357
Lines 6583 6594 +11
Branches 676 677 +1
============================================
+ Hits 5963 5974 +11
Misses 417 417
Partials 203 203 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this PR! I directly committed some changes, since I didn't find a solution without coding it directly...
see https://issues.jenkins.io/browse/JENKINS-73933
file paths in file uri scheme are converter to normal paths
Submitter checklist