Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dependencies #1088

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Cleanup dependencies #1088

merged 6 commits into from
Sep 13, 2024

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Sep 11, 2024 •
edited
Loading

Fix Maven dependency errors.

  • Remove shading for ASM.
  • Remove bcel and jcommander.
  • Cleanup other dependencies.

Also cleanup several ErrorProne warnings.

@uhafner
Cleanup dependencies.
652ecf9 
Remove shading for ASM.
Remove bcel and jcommander.
Cleanup other dependencies.
@uhafner uhafner added the bug Bugs or performance problems label Sep 11, 2024
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 1283 passed, 🙈 2 skipped)
   〰️   Line Coverage: 94% (410 missed lines)
   ➰   Branch Coverage: 88% (256 missed branches)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 1283 passed, 🙈 2 skipped)
   〰️   Line Coverage: 94% (410 missed lines)
   ➰   Branch Coverage: 88% (256 missed branches)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.96552% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.67%. Comparing base (7eb9a14) to head (704f464).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...va/edu/hm/hafner/analysis/FullTextFingerprint.java 50.00% 1 Missing ⚠️
.../edu/hm/hafner/analysis/parser/BrakemanParser.java 50.00% 1 Missing ⚠️
...afner/analysis/parser/findbugs/FindBugsParser.java 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1088      +/-   ##
============================================
- Coverage     90.74%   90.67%   -0.07%     
+ Complexity     2322     2299      -23     
============================================
  Files           355      355              
  Lines          6551     6502      -49     
  Branches        675      665      -10     
============================================
- Hits           5945     5896      -49     
  Misses          410      410              
  Partials        196      196

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 12, 2024
View reviewed changes
src/main/java/edu/hm/hafner/analysis/parser/ccm/CcmParser.java

return convert(report);
}

private Ccm parseCCMXmlFile(final ReaderFactory ccmXmlFile) {
SecureDigester digester = new SecureDigester(CcmParser.class);
private Ccm parseCcmXmlFile(final ReaderFactory ccmXmlFile) {

Check warning

Code scanning / Jenkins Security Scan

Jenkins: Potentially unsafe classes Warning

This use of class
org.apache.commons.digester3.Digester
Loading
should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 1283 passed, 🙈 2 skipped)
   〰️   Line Coverage: 94% (410 missed lines)
   ➰   Branch Coverage: 87% (256 missed branches)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: 1 warning (0 error, 0 high, 0 normal, 1 low)

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 1283 passed, 🙈 2 skipped)
   〰️   Line Coverage: 94% (410 missed lines)
   ➰   Branch Coverage: 87% (256 missed branches)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: 1 warning (0 error, 0 high, 0 normal, 1 low)

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 1283 passed, 🙈 2 skipped)
   〰️   Line Coverage: 94% (410 missed lines)
   ➰   Branch Coverage: 87% (256 missed branches)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@uhafner uhafner merged commit 6f2d128 into main Sep 13, 2024
12 of 15 checks passed
@uhafner uhafner deleted the remove-asm-shading branch September 13, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs or performance problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uhafner