Add placeholder image and contributor alt text #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krisstern Whenever I am opening the link for jenkins/infra.ci.jenkins.io/website-jobs/plugin-site/pr-merge - This commit cannot be built - the page is not loading . Could you confirm if this is expected or if there's an issue with the build? |
|
It may be expected, since I have seen it before |
|
Got it, thanks for the info! |
|
@timja @krisstern I’ve made the changes as discussed. Could you review and let me know if they’re correct or if any further work is needed? Thanks! |
|
c.c. @zbynek |
|
Thanks @krisstern and @zbynek for the reviews !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2102 , fixes the image loading issue by adding a placeholder image and setting the alt text to "Contributor" until the fetch process is completed