Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Modes" trait from SECURITYSYSTEM device #99

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

alexismdr
Copy link

Description

"Modes" is neither a required nor a recommended trait for a SECURITYSYSTEM device. Different Arm Levels are handled by ArmDisarm trait. Removed it.

Suggested changelog entry

Removed useless "Modes" trait from SECURITYSYSTEM device.

Related issues/external references

https://developers.home.google.com/cloud-to-cloud/guides/securitysystem

Types of changes

  • Bug fix (non-breaking change which fixes)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the GNU.
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added MD documentation for the sniff.

"Modes" is neither a required nor a recommended trait for a SECURITYSYSTEM device. Different Arm Levels are handled by ArmDisarm trait.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant