-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Matching content in our doctests #197
base: master
Are you sure you want to change the base?
[WIP] Matching content in our doctests #197
Conversation
Hi @jbesomi, Based on the runners, the doctests for Python 3.6 are not valid due that However, the doctests for Python 3.X (with X >= 7) are valid because Do you have any idea about this issue? |
Hi @k0pernicus, thank you for your PR! Amazing 🎉 Regarding the issue with |
Hi @jbesomi, thank you for the update :)
Great! |
Hi @jbesomi , |
Hi @k0pernicus, I've intensively thought about this and come to the conclusion that it's better for both of us developers and for all Texthero users to have all preprocessing functions to accept an already Tokenized Series. See here #145 for a complete discussion on the subject. Would you like to help with #145 too? Once implemented, writing |
Thank you @k0pernicus ! |
This PR solves issue #189 in order to match the content in our doctests.
I updated all the sources in the
texthero
folder - the main issue is in thescatterplot
function, invisualization.py
, where the 3D representation on the browser does not show anything (WiP).I also updated the file CONTRIBUTING.md in order to inform the project contributors to match as much as possible the doctests in their examples / tests.
To finish, I also updated some doctests in order to add a new line between the doc and the source code sometimes (for clarity), to remove extra whitespaces, etc...