-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize hero.describe with plots #178
base: master
Are you sure you want to change the base?
Visualize hero.describe with plots #178
Conversation
suport MultiIndex as function parameter returns MultiIndex, where Representation was returned * missing: correct test Co-authored-by: Henri Froese <[email protected]>
*missing: test adopting for new types Co-authored-by: Henri Froese <[email protected]>
- add functionality for decorator @InputSeries to handle several allowed input types - Add typing decorator/hints to representation.py - add tests for _types DocumentTermDF Co-authored-by: Maximilian Krahn <[email protected]>
Co-authored-by: Maximilian Krahm <[email protected]>
…describe_function"
Co-authored-by: Henri Froese <[email protected]>
Co-authored-by: Henri Froese <[email protected]>
…nto visualize_describe_with_plots
That's beautiful! 😍
|
Currently we get an error but that's just because of the default arguments (see below). Agree we should test that behavior for all hero functions, probably in a separate PR in the future.
We tried it out and think it looks good as-is on 13 inch screens (which is the standard "small" laptop size). From your review
Yes, the default arguments really make no sense, we just used them for testing purposes and forgot to remove them 🤦 🤦♂️ 🤦♀️ Additionally, not sure what you mean / how we would integrate several text columns? We thought that there are two main scenarios:
Additionally just noticed that there isn't a docstring (totally forgot this). Will convert this to draft and address all concerns + add docstring. Will update here and post screenshots when it's done. |
- Docstring - Better signature
Now changed the function signature to be in line with We noticed that this function cannot handle empty input because of Note: the merge conflicts should be resolved when we're farther along the merge checklist; we'll revisit this |
we just went through this PR again and it is ready to be reviewed / to be merged 🔢 🧶 |
This new function in the visualization module allows users to easily visualize the describe function. We belive, that this will be often use, to display the key characteristics of the DataFrame. 🥉
This function simply calls the describe functions and then with plotly those plots will be generated and displayed in a new browser window. As it is a lot of code to display them, we belive, that it will be quite an enrichment to the library 🏑
Note: travis/setup changed because of #171 . This is branched straight from PR #168 which is why it has so many lines changed 🥡 .
This is a short colab demo of the new function 🤖