-
Notifications
You must be signed in to change notification settings - Fork 8
Sync with upstream @ fb4fc33a #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor edits for grammar, phrasing, and markup.
Edited according to feedback
Rewrote phrasing pointed out in feedback
To be coherent with the solution and the picture below.
remove unnecessary 'in'
- comments are in pairs. The first of the pair talks about what happened "caching" and the second pair talks about what was alerted "the same". This is confusing. - changed comment so both lines tell the reader what happened and what result was returned.
A minor addition. (...where such thing doesn't happen. --> where such a thing doesn't happen.)
I think argN represents count of arbitrary parameters. But this syntax looks like "rest syntax". It could be more understandable to change it like this.
conflict with "rest syntax"
Update article.md
…rer-comments Clearer CachingDecorator comments
Add missing semicolon in Arrow Functions (1-6-12)
Improve modyfying document task one sentence grammar
there are four logical operators in JS
fix undefined to pass test
fix typo: missing semicolon after let ladder = { }
Fix typo in "liseners" on line 21
FIX: minor typo error
FIX: The range of hexadecimal numbers is 0-9 or A-F
easier to read
"not required" vs "incorrect"
Update article.md
Remove mentions of :host-context
fix typo in 1-js/05-data-types/03-string
|
siddiqkaithodu
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to merge changes from en.javascript.info at fb4fc33
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
git checkout master
git pull upstream master
git checkout --ours <path>
git diff --word-diff master...upstream/master <path>
(please note: three dots in the command)git push origin master
This PR will be closed and replaced with a new one in a few days.