Sync with upstream @ 035c5267 #89
Closed
+2,746
−725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update String type chapter
fix markdown syntax
Update solution.md
Missing '()' invoking a constructor.
contextually 'true' can be confusing after 'false' in sentence: "... false, technically that's true ..."
Parentheses can be omitted even if the constructor function has arguments:
```js
new function(test) {
return { test }
}
// Works the same as
new (function(test) {
return { test }
})();
```
Firefox v105 also shows `10px`.
Remove description of inconsistency between Chrome and Firefox
ECMA broken link
Fix typo "stirng" to "string"
Change link to the spec
minor fix to function name written in explanation
Suggested edit - to make the phrase clearer.
the comment number is missing when the we mention line 2
Improve readability
Grammatical fix
Update article.md
Update article.md
better wording
Correction of grammatical error
Update article.md
Fixed missing closing parenthesis
|
|
www-learn-en
force-pushed
the
sync-035c5267
branch
from
ceb4fac to
f4fe6dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to merge changes from en.javascript.info at 035c526
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.infogit checkout mastergit pull upstream mastergit checkout --ours <path>git diff --word-diff master...upstream/master <path>(please note: three dots in the command)git push origin masterPlease ignore changes in README.md (git checkout --ours README.md && git commit -m ignore README.md).
This PR will be closed and replaced with a new one in a few days.