Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currying #307

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Currying #307

merged 2 commits into from
Sep 11, 2023

Conversation

moAlireza
Copy link
Contributor

@moAlireza moAlireza commented Sep 11, 2023

  • I tried my best to keep the translation simple and easy to understand.

  • Also lines are the same as in the English article (but it would be good if it gets reviewed again)

  • I had some struggles with the direction of smart headers (they were LTR) so I added <div dir="rtl"> in line 164 to make them RTL. If it could be the cause of any problem or it is not good, feel free to remove it and fix the problem of smart headers direction, or just give me the solution and I'll make it fine.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the additional html tags since it'll cause conflicts.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@moAlireza
Copy link
Contributor Author

/done

Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @moAlireza!

@mahdyar mahdyar merged commit 49b47e3 into javascript-tutorial:master Sep 11, 2023
@javascript-translate-bot

Error: the article has another PR number in the Progress Issue #1, it's 304, not 307 ⁉️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants